Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain composer to 2.2+ to try and force default platform reqs #88

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

After #87 was merged, renovate continues to run with --ignore-platform-reqs set. This is most likely due to our composer requirement of either v1 or v2.

This PR attempts to coerce renovate into using its defaults of --ignore-platform-req='ext-*' --ignore-platform-req='lib-*'. If this doesn't work then we may need to disable composerIgnorePlatformReqs altogether, or drop support for composer v1.

Signed-off-by: Gary Lockett <gary@creativecow.uk>
@Ocramius Ocramius added Enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 25, 2022
@Ocramius Ocramius self-assigned this Oct 25, 2022
@Ocramius Ocramius added this to the 3.12.0 milestone Oct 25, 2022
@Ocramius
Copy link
Member

Let's try this 👍

@Ocramius Ocramius merged commit c0793d4 into mezzio:3.12.x Oct 25, 2022
@internalsystemerror internalsystemerror mentioned this pull request Oct 25, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants