Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.2, drop support for PHP 7.4 #105

Merged
merged 12 commits into from
Dec 10, 2022
Merged

Add support for PHP 8.2, drop support for PHP 7.4 #105

merged 12 commits into from
Dec 10, 2022

Conversation

ghostwriter
Copy link
Contributor

@ghostwriter ghostwriter commented Nov 16, 2022

Q A
QA yes

Description

  • Update composer config platform.php to 8.0.99
  • Update composer PHP to ~8.0.0 || ~8.1.0 || ~8.2.0
  • Ignore PHP platform requirements via .laminas-ci.json
  • Resolves Support for PHP 8.2 #103

@Ocramius
Copy link
Member

@weierophinney we probably need a new build of swoole here 😬

@weierophinney
Copy link
Contributor

we probably need a new build of swoole here

Will get it built later today!

@weierophinney
Copy link
Contributor

Support is ready, and I've created a PR for laminas-continuous-integration-action (laminas/laminas-continuous-integration-action#139) to allow using the new packages. When that's released, we can rerun the PHP 8.2 jobs.

@Ocramius
Copy link
Member

@ghostwriter
Copy link
Contributor Author

E: Unable to locate package php8.2-inotify

@Ocramius
Copy link
Member

Where do we install inotify? Manually?

@weierophinney
Copy link
Contributor

Where do we install inotify? Manually?

Every other PHP version we install on has this pre-built; it's why we have it i the .laminas-ci.json file. However, for 8.2... Ondrej has not included it (yet).

We may have to build it in the CI container. 🙁

@ghostwriter
Copy link
Contributor Author

We tell the ci to install it, via .laminas-ci.json

testing locally…

docker run -v $(pwd):/github/workspace -w=/github/workspace ghcr.io/laminas/laminas-continuous-integration:1.30 '{"command":"./vendor/bin/phpunit","php":"8.2","extensions":["inotify","swoole"],"ini":[],"dependencies":"locked"}'

@froschdesign froschdesign changed the title Feature: Support PHP 8.2 Add support for PHP 8.2, drop support for PHP 7.4 Nov 16, 2022
@Ocramius Ocramius mentioned this pull request Nov 17, 2022
@ghostwriter
Copy link
Contributor Author

Successfully installed packaged extensions: php8.2-inotify,

Ready for review.

@Ocramius
Copy link
Member

Ocramius commented Dec 9, 2022

Could this be rebased, rather than merged?

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @ghostwriter!

@Ocramius Ocramius merged commit 29a57bf into mezzio:4.6.x Dec 10, 2022
@Ocramius Ocramius self-assigned this Dec 10, 2022
@Ocramius Ocramius added the Enhancement New feature or request label Dec 10, 2022
@Ocramius Ocramius added this to the 4.6.0 milestone Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PHP 8.2
3 participants