Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PHP 8.0 #117

Merged
merged 1 commit into from
May 9, 2023
Merged

Remove support for PHP 8.0 #117

merged 1 commit into from
May 9, 2023

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented May 9, 2023

since mezzio has dropped support for php 8, there is no need that mezzio-swoole support it.

see mezzio/mezzio@db61148

@fezfez fezfez changed the title drop php 8 support Remove support for PHP 8.0 May 9, 2023
@gsteel
Copy link
Member

gsteel commented May 9, 2023

Thanks @fezfez - Can you also remove the 'ignore-platform-reqs' in .laminas-ci.json please?

"ignore_php_platform_requirements": {
"8.2": true
}

@gsteel gsteel added this to the 4.7.0 milestone May 9, 2023
@gsteel gsteel added the Enhancement New feature or request label May 9, 2023
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez
Copy link
Contributor Author

fezfez commented May 9, 2023

Thanks @fezfez - Can you also remove the 'ignore-platform-reqs' in .laminas-ci.json please?

"ignore_php_platform_requirements": {
"8.2": true
}

done

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez

@gsteel gsteel merged commit ae9868b into mezzio:4.7.x May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants