Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependency symfony/console to ^5.3 || ^6.0.19 || ^7.0 #134

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

grizzm0
Copy link
Contributor

@grizzm0 grizzm0 commented Sep 10, 2024

Allow symfony/console ^7.0.

Command::$defaultName has been replaced with #[AsCommand()] in 7.0. This was first introduced in 5.3 which is why the minimum version was raised.

This also requires dropping support for php 8.1.

@grizzm0 grizzm0 changed the title Updated dependency symfony/console to ^5.0 || ^6.0.19 || ^7.0 Updated dependency symfony/console to ^5.3 || ^6.0.19 || ^7.0 Sep 10, 2024
Signed-off-by: Kristofer Karlsson <karlsson.kristofer@gmail.com>
Signed-off-by: Kristofer Karlsson <karlsson.kristofer@gmail.com>
@froschdesign

This comment was marked as off-topic.

@Ocramius

This comment was marked as off-topic.

@Ocramius Ocramius added Enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 10, 2024
@Ocramius Ocramius added this to the 4.10.0 milestone Sep 10, 2024
src/Command/StatusCommand.php Outdated Show resolved Hide resolved
@froschdesign

This comment was marked as off-topic.

@Ocramius

This comment was marked as off-topic.

@Ocramius

This comment was marked as off-topic.

@froschdesign

This comment was marked as off-topic.

Signed-off-by: Kristofer Karlsson <karlsson.kristofer@gmail.com>
@alexmerlin
Copy link
Member

@Ocramius @froschdesign Anything else blocking this PR from being merged?

@Ocramius
Copy link
Member

@alexmerlin at first look, seems good to go

@arhimede arhimede merged commit 54477ef into mezzio:4.10.x Oct 15, 2024
9 checks passed
@grizzm0
Copy link
Contributor Author

grizzm0 commented Oct 16, 2024

Could we ship 4.10 as well? :)

@alexmerlin
Copy link
Member

@gsteel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants