Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis to Laminas CI workflow #64

Merged
merged 8 commits into from
May 26, 2021

Conversation

weierophinney
Copy link
Contributor

@weierophinney weierophinney commented May 26, 2021

This patch updates the project to use the GitHub Actions-based Laminas CI workflow, and does the following:

  • removes the CHANGELOG.md (changelogs will be kept in milestone descriptions)
  • replaces Travis with Laminas CI configuration
  • moves phpcs.xml to phpcs.xml.dist

Fixes #61

Changelogs will be kept in the milestone description, and propagated to tag and release notes.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Removes `.travis.yml`
- Adds Laminas CI workflow
- Adds configuration to Laminas CI workflow to install inotify and swoole extensions

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
To allow developers to selectively modify what is being checked locally.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney added this to the 3.3.1 milestone May 26, 2021
@weierophinney weierophinney added the Enhancement New feature or request label May 26, 2021
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Alignment of assignment operators

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Newer version of psalm has flagged more items than we had previously.
Now that we have a lockfile, we can prevent that from happening next time, but a large number of these are known and expected (particularly unused closure and function parameters in test cases).

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney linked an issue May 26, 2021 that may be closed by this pull request
@weierophinney weierophinney merged commit 0ead564 into mezzio:3.3.x May 26, 2021
@weierophinney weierophinney deleted the feature/github-actions branch May 26, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GHA CI workflow
1 participant