Provide PHP 8.1 support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch provides PHP 8.1 support, via the following changes: - Adds `~8.1.0` to the list of allowed PHP versions. - Marks a conflict with symfony/console versions prior to 5.3.11 (first version supporting PHP 8.1) - Replaces usage of `gmstrftime()` with a combination of casting timestamps to `DateTimeImmutable` objects with a GMT timezone, and using `IntlDateFormatter::formatObject()` with an equivalent date/time format to what was used with `gmstrftime()`. - Adds `#[\ReturnTimeWillChange]` attributes to classes implementing `JsonSerialize` to ensure they remain both backwards and forwards compatible. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
feature/php-8.1-support
branch
from
797dbcd
to
3f7b5bf
Compare
|
If you can release mezzio/mezzio#96 (and agree with it), we can probably even skip the |
There's enough third-party requirements that my guess is we'd still have to. :) |
|
@Ocramius laminas-coding-standard isn't compatible yet, which is the blocker for skipping |
Ocramius
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides PHP 8.1 support, via the following changes:
~8.1.0to the list of allowed PHP versions.gmstrftime()with a combination of casting timestamps toDateTimeImmutableobjects with a GMT timezone, and usingIntlDateFormatter::formatObject()with an equivalent date/time format to what was used withgmstrftime().#[\ReturnTimeWillChange]attributes to classes implementingJsonSerializeto ensure they remain both backwards and forwards compatible.