Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace documentation for disabling static resources #80

Merged

Conversation

weierophinney
Copy link
Contributor

With the v3 release, this configuration is no longer relevant; instead, you need to redefine the set of listeners for the RequestEvent to omit the StaticResourceRequestListener.

Note to @froschdesign: I did not use an admonition here as it was multiple paragraphs + code sample.

Fixes #60

With the v3 release, this configuration is no longer relevant; instead, you need to redefine the set of listeners for the `RequestEvent` to omit the `StaticResourceRequestListener`.

Fixes mezzio#60

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney added this to the 3.6.0 milestone Dec 13, 2021
@weierophinney weierophinney added Documentation Bug Something isn't working labels Dec 13, 2021
@weierophinney weierophinney merged commit 05e19b9 into mezzio:3.6.x Dec 13, 2021
@weierophinney weierophinney deleted the hotfix/static-files-enable-flag branch December 13, 2021 21:43
@froschdesign
Copy link
Member

@weierophinney
But you can and should use an admonition because the HTML blockquote element is wrong.
An example for longer text with headline and code sample can be found in laminas-i18n: https://github.com/laminas/laminas-i18n/blob/2.14.x/docs/book/view-helpers/introduction.md?plain=1#L26-L43

@weierophinney
Copy link
Contributor Author

@froschdesign OH! I missed that you can do it WITHIN the blockquote formatting! That was why I'd not done it!

Will push a change that reflects that - thanks!

@weierophinney
Copy link
Contributor Author

@froschdesign Done in da60ea0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused configuration property "enable" and misleading documentation about static resources
2 participants