Provide a chapter on adding a request ID #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
reviewed
Jan 3, 2022
froschdesign
requested changes
Jan 4, 2022
| However, when using mezzio-swoole, the request handler runner we create is your web server. | ||
| It has listeners that take care of logging, which means that the request generated must _already_ have the identifier if you want to be able to log it. | ||
|
|
||
| This poses a problem: normally you will use middleware to propagate changes to the request. |
There was a problem hiding this comment.
Until here the problem is described, therefore the the headline "The solution" is wrong before these lines.
| This poses a problem: normally you will use middleware to propagate changes to the request. | ||
| How can you do it at the Swoole web server level? | ||
|
|
||
| The answer is deceptively simple: you can provide a [delegator factory](https://docs.mezzio.dev/mezzio/v3/features/container/delegator-factories/) for decorator on the service that converts the Swoole HTTP request instance into the equivalent [PSR-7](https://www.php-fig.org/psr/psr-7/) HTTP request instance that is then passed to your application. |
There was a problem hiding this comment.
Maybe it is simple for you but it does not mean that it applies to others as well. So do not use "simple" or "easy" in the documentation.
Based on a question I answered in Slack, this provides a recipe for adding a unique request ID that can then be tracked in your logs. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Move description of the problem... under the heading marked "The problem". - Remove "simple" verbiage. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Performs one more editing pass, identifying several grammatical and/or spelling errors. Also updates the example to use an arrow function. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
docs/request-id-recipe
branch
from
52d7c2b
to
5169788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a question I answered in Slack, this provides a recipe for adding a unique request ID that can then be tracked in your logs.