Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/log:^2 and psr/log:^3 installation #88

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Allow psr/log:^2 and psr/log:^3 installation #88

merged 4 commits into from
Feb 15, 2022

Conversation

byan
Copy link
Contributor

@byan byan commented Feb 15, 2022

No description provided.

Signed-off-by: Ben Yan <i@yanbin.org>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.lock needs updating too.

@Ocramius Ocramius added the Enhancement New feature or request label Feb 15, 2022
Signed-off-by: Ben Yan <i@yanbin.org>
@Ocramius Ocramius added this to the 4.2.0 milestone Feb 15, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP Fatal error:  Declaration of Mezzio\Swoole\Log\Psr3AccessLogDecorator::emergency($message, array $context = []) must be compatible with Psr\Log\LoggerInterface::emergency(Stringable|string $message, array $context = []): void in /github/workspace/src/Log/Psr3AccessLogDecorator.php on line 64

Signed-off-by: Ben Yan <i@yanbin.org>
@Ocramius
Copy link
Member

These need some more adjustments:

Error: Method \Mezzio\Swoole\Log\StdoutLogger::emergency() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::alert() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::critical() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::error() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::warning() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::notice() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::info() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::debug() has useless @return annotation.
Error: Method \Mezzio\Swoole\Log\StdoutLogger::log() has useless @return annotation.

Signed-off-by: Ben Yan <i@yanbin.org>
@Ocramius Ocramius self-assigned this Feb 15, 2022
@Ocramius Ocramius changed the title Update psr/log Allow psr/log:^2 and psr/log:^3 installation Feb 15, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @byan!

@Ocramius Ocramius merged commit 4067c94 into mezzio:4.2.x Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants