Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Renovate with reusable workflows #89

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Prepare for Renovate with reusable workflows #89

merged 4 commits into from
Feb 21, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@Ocramius Ocramius added the Enhancement New feature or request label Feb 21, 2022
@Ocramius Ocramius added this to the 4.3.0 milestone Feb 21, 2022
@Ocramius Ocramius self-assigned this Feb 21, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghostwriter I see all these patches come with a composer update - that's a problem, because we shifted dependencies. Perhaps composer update --lock? Can the Update composer dependencies commit be dropped?

Also, I suggest sending one patch as a start, to see if it works, before replicating it everywhere, since otherwise you will get a bunch of reviews by other maintainers on different patches like this one :D

@ghostwriter
Copy link
Contributor Author

@Ocramius Just following step 5, composer update https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

dropped commit Update composer dependencies, as requested.

composer.json Show resolved Hide resolved
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghostwriter!

@Ocramius Ocramius merged commit 81503e3 into mezzio:4.3.x Feb 21, 2022
@ghostwriter ghostwriter deleted the feature/renovate branch February 21, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants