Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numbering of interrupt lines for 8018X #85

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix numbering of interrupt lines for 8018X #85

merged 2 commits into from
Dec 6, 2023

Conversation

mfld-fr
Copy link
Owner

@mfld-fr mfld-fr commented Dec 3, 2023

See discussion in PR #84 about interrupt line numbering.

@cocus @robots : could you please review the changes ?

@mfld-fr mfld-fr added the fix Defect correction label Dec 3, 2023
@mfld-fr mfld-fr self-assigned this Dec 3, 2023
@robots
Copy link
Contributor

robots commented Dec 4, 2023

It looks good.

int-8018x.c Outdated Show resolved Hide resolved
@cocus
Copy link
Contributor

cocus commented Dec 4, 2023

I think these are fine! I was using an -EB as well, so no wonder why some stuff wasn't working on the emu86 but it worked on the phisical hardware. Thank you.

@mfld-fr
Copy link
Owner Author

mfld-fr commented Dec 6, 2023

Thanks @robots and @cocus for the review !

@mfld-fr mfld-fr merged commit 429971f into master Dec 6, 2023
4 checks passed
@mfld-fr mfld-fr deleted the int_num branch December 6, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Defect correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants