Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTP support #530

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Add RTP support #530

merged 1 commit into from
Mar 31, 2024

Conversation

jamestiotio
Copy link
Contributor

This commit adds support for the Real-time Transport Protocol (RTP) as defined in RFC 3550. Some tests have also been added to ensure that the RTP PDU class functionality is working as expected.

Note to reviewer: please double-check the parts that handle endian conversions. Initially, I was a little confused regarding the conversions. While I eventually managed to wrap my head around it, ensuring that the implementation handles these conversions correctly would be really appreciated. Thank you!

Copy link
Owner

@mfontanini mfontanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! I'll play around with this a bit once the comments are addressed.

include/tins/rtp.h Outdated Show resolved Hide resolved
include/tins/rtp.h Outdated Show resolved Hide resolved
src/rtp.cpp Show resolved Hide resolved
src/rtp.cpp Outdated Show resolved Hide resolved
src/rtp.cpp Outdated Show resolved Hide resolved
src/rtp.cpp Outdated Show resolved Hide resolved
src/rtp.cpp Outdated Show resolved Hide resolved
src/rtp.cpp Outdated Show resolved Hide resolved
include/tins/rtp.h Outdated Show resolved Hide resolved
@jamestiotio jamestiotio force-pushed the rtp branch 4 times, most recently from 52c4117 to 6c662d4 Compare March 21, 2024 13:36
@jamestiotio
Copy link
Contributor Author

I have improved the code to ensure that it's RFC-compliant by throwing a malformed_packet exception when appropriate. I have also added tests to ensure that the malformed_packet exception is thrown when it should be.

@jamestiotio jamestiotio force-pushed the rtp branch 2 times, most recently from 491daa2 to d6c7296 Compare March 21, 2024 14:53
Copy link
Owner

@mfontanini mfontanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've been quite busy. Just one comment, I tested this locally and it seems to work great!

src/rtp.cpp Outdated Show resolved Hide resolved
This commit adds support for the Real-time Transport Protocol (RTP) as
defined in RFC 3550. Some tests have also been added to ensure that the
RTP PDU class functionality is working as expected.

Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
@mfontanini mfontanini merged commit fe22186 into mfontanini:master Mar 31, 2024
2 checks passed
@mfontanini
Copy link
Owner

Awesome, thanks for staying on top of the PR and sorry again for the delay!

@jamestiotio
Copy link
Contributor Author

No worries, thank you for your time!

@jamestiotio jamestiotio deleted the rtp branch April 2, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants