Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://validator.w3.org/ reports errors #90

Closed
denyshutsal opened this issue Jul 8, 2020 · 2 comments · Fixed by #95
Closed

https://validator.w3.org/ reports errors #90

denyshutsal opened this issue Jul 8, 2020 · 2 comments · Fixed by #95
Assignees
@mfranzke
Labels
bug Something isn't working
Milestone
2.0

Comments

@denyshutsal
Copy link

denyshutsal commented Jul 8, 2020 •
edited
Loading

https://validator.w3.org/ reports errors

Снимок
@mfranzke
Copy link
Owner

mfranzke commented Jul 8, 2020

great catch, thanks a lot, @denyshutsal ! This could be a late answer and clearly point the decision/answer out of #11 in the other direction, and might lead to a breaking change within the HTML code with one of the next releases to have this fixed.

@denyshutsal
Copy link
Author

Many thanks

@mfranzke mfranzke added this to the 2.0 milestone Feb 9, 2021
mfranzke pushed a commit that referenced this issue Feb 14, 2021
fix: w3c errrors #90
3fa4cf3
@mfranzke mfranzke self-assigned this Feb 14, 2021
@mfranzke mfranzke added the bug Something isn't working label Feb 14, 2021
@mfranzke mfranzke mentioned this issue Feb 14, 2021
Merged
mfranzke added a commit that referenced this issue Mar 4, 2021
@mfranzke
fix: w3c errors (#90)
43dc20c 
* fix: w3c errrors #90

* refactor(changelog): extracted the migration guide

* docs(contributor): added contributor

* chore(changelog): clearified the changelog entry

* chore(migration): corrected the headline hierarchy

* chore: regenerated the minified JS file

* chore: regenerated the minified file

* refactor(docs): using direct github link

* chore(docs): further optimized the issue links

* chore: regenerated minified javascript file

* chore(changelog): slight adjustments

Co-authored-by: Maximilian Franzke <mfr@nzke.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfranzke mfranzke

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

fix: w3c errors mfranzke/loading-attribute-polyfill
2 participants
@mfranzke @denyshutsal