Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: use stdin #457

Closed
wants to merge 2 commits into from
Closed

codespell: use stdin #457

wants to merge 2 commits into from

Conversation

Jendker
Copy link
Contributor

@Jendker Jendker commented Nov 13, 2023

No description provided.

Copy link
Owner

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but this is way too complex and it wouldn't work on PUC Lua 5.1 because it has no goto

Does codespell support output format options? Or is it possible to use a different errorformat pattern instead?

@Jendker
Copy link
Contributor Author

Jendker commented Nov 17, 2023

Hi @mfussenegger, thank you for looking into this!

I have created a PR to codespell which will make parsing easier. codespell-project/codespell#3224
Let's see how it goes from there.

@Jendker
Copy link
Contributor Author

Jendker commented Nov 17, 2023

@mfussenegger there is a discussion going in my codespell PR: codespell-project/codespell#3224 Please feel free to add any comments there.

@Jendker
Copy link
Contributor Author

Jendker commented Nov 20, 2023

The codespell changes have been merged an I will be able to vastly simplify this PR. I'll wait for the release of codespell and then push new version of the code.

@mfussenegger
Copy link
Owner

Closing this for now. Please open a new PR once the codespell release is out and you've adapted it to that.

@Jendker Jendker mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants