Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13 Config file error : PyYAML yaml.load(input) #14

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

bsridatta
Copy link
Contributor

Updating Deprecation yaml load function
Changing to yaml.safe_load(default_params_yaml)

Should also be able to change to any of-
yaml.safe_load
yaml.full_load
yaml.unsafe_load

@bsridatta bsridatta changed the title Fixed #13 Config file error : PyYAML yaml.load(input) Deprecation Fixed #13 Config file error : PyYAML yaml.load(input) Mar 6, 2019
@mfxox
Copy link
Owner

mfxox commented Mar 7, 2019

@bsridatta Thank you for you PR. Could you make it compatible for old pyyaml version also?
For example, use "if" to decide using "load" or "safe_load" after checking the version of pyyaml.

@bsridatta
Copy link
Contributor Author

bsridatta commented Mar 7, 2019 via email

@mfxox mfxox merged commit 2f7be6b into mfxox:master Mar 7, 2019
@mfxox
Copy link
Owner

mfxox commented Mar 7, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants