Skip to content

Commit

Permalink
sql/logictest: remove assignment cast TODO
Browse files Browse the repository at this point in the history
This commit removes a TODO that was partially addressed by cockroachdb#82022.

Informs cockroachdb#73743

Release note: None
  • Loading branch information
mgartner committed Aug 14, 2024
1 parent df21186 commit 23b5d31
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/sql/logictest/testdata/logic_test/cast
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,7 @@ PREPARE insert_f4 AS INSERT INTO assn_cast(f4) VALUES ($1)
statement ok
EXECUTE insert_f4(18754999.99)

# TODO(mgartner): Values are not correctly truncated when cast to FLOAT4, either
# in an assignment or explicit context. The columns should have a value of
# 1.8755e+07. See #73743.
query F
query F rowsort
SELECT f4 FROM assn_cast WHERE f4 IS NOT NULL
----
1.8755e+07
Expand Down

0 comments on commit 23b5d31

Please sign in to comment.