Skip to content

Commit

Permalink
sem/tree: remove TODO
Browse files Browse the repository at this point in the history
This commit removes a TODO that was addressed by cockroachdb#96045.

Release note: None
  • Loading branch information
mgartner committed Apr 20, 2023
1 parent fe19f93 commit fc6c97c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/sql/sem/tree/function_definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,6 @@ func (fd *ResolvedFunctionDefinition) MatchOverload(
) (QualifiedOverload, error) {
matched := func(ol QualifiedOverload, schema string) bool {
if ol.IsUDF {
// TODO(mgartner/chengxiong-ruan): Differentiate between functions
// defined with `Body` and UDFs, now that we use `Body` for built-in functions.
return schema == ol.Schema && (paramTypes == nil || ol.params().MatchIdentical(paramTypes))
}
return schema == ol.Schema && (paramTypes == nil || ol.params().Match(paramTypes))
Expand Down

0 comments on commit fc6c97c

Please sign in to comment.