Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use visual_file_name (csv's name) instead of geo_file_name for output #217

Closed
adisidev opened this issue Nov 13, 2024 · 1 comment · Fixed by #220
Closed

Use visual_file_name (csv's name) instead of geo_file_name for output #217

adisidev opened this issue Nov 13, 2024 · 1 comment · Fixed by #220
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority: high

Comments

@adisidev
Copy link
Collaborator

std::string map_name = cart_info.set_map_name(geo_file_name);

@adisidev adisidev self-assigned this Nov 13, 2024
@adisidev adisidev added documentation Improvements or additions to documentation enhancement New feature or request priority: high labels Nov 13, 2024
@adisidev
Copy link
Collaborator Author

One input geo_file could result in multiple cartograms depending on the CSV file it is used with. However, each CSV would only correspond to one output cartogram. Thus, the unique output identifier would be the csv's name, not the map file's name.

For example, australia_by_state_and_territory_since_1942_cartogram.geojson vs australia_population_2021_cartogram.geojson: the latter is far better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority: high
Projects
None yet
1 participant