Revise CSV naming convention, update README, and improve CMakeLists.txt compatibility #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihalzp
previously approved these changes
Nov 28, 2024
|
|
||
| #### Installing dependencies through Homebrew | ||
|
|
||
| Install pkg-config, boost, fftw, nlohmann-json, and cmake by running the following command: | ||
|
|
||
| brew install libomp pkg-config boost fftw nlohmann-json cmake cairo | ||
| ```shell script | ||
| brew install libomp pkg-config boost fftw nlohmann-json cmake cairo |
There was a problem hiding this comment.
I feel nlohmann-json should be added to our repo's external folder as third party, and can be removed from here.
There was a problem hiding this comment.
I don't think that is a good idea, because then we would have even more extra files. Let's us cross that bridge when nlohmann fails us.
nihalzp
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the CSV naming convention for clarity (fixes #217), enhance the installation guide with ownership instructions, and update the CMake configuration for better compatibility.
Additionally:
worldexample for runningcartogram(fixes Add options in README and add an actual example to run the generator from the build directory #74)stress_test.sh, append CLI arguments instead of replacing them (fixes Instress_test.sh, CLI should be appended instead of replaced. #216)