Add GitHub Action to Automatically Create Releases #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces Docker image creation
* Removed matplot++ dependency * Downgraded cmake, gcc, g++ versions to be compatible with Ubuntu 22.04 out of the box * Changed -isystem flags to -I as it was affecting how gcc was searching for header files
For testing of new cartogram binary
We need to figure out why removing this line makes it not possible to compile on macOS anymore.
adisidev
force-pushed
the
pr/adisidev/201
branch
from
4b0cfb2 to
6c4a1c7
Compare
adisidev
force-pushed
the
pr/adisidev/201
branch
from
6c4a1c7 to
d003e8e
Compare
nihalzp
previously approved these changes
Nov 6, 2024
nihalzp
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @Wind1337.
This was previously opened as #201 , however, that had breaking changes on macOS. Thus, I've made the new CMakeLists.txt work on macOS and merged the previous changes from Carlsen, retaining the correct commit history so that Carlsen can be correctly credited.