cmake libretro "Visual Studio 15 2017" #1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endrift
requested changes
Oct 1, 2018
include/mgba-util/common.h
Outdated
| @@ -46,6 +46,7 @@ typedef intptr_t ssize_t; | |||
| #define snprintf _snprintf | |||
| #define strdup _strdup | |||
| #define lseek _lseek | |||
| #define __builtin_bswap32 _byteswap_ulong | |||
There was a problem hiding this comment.
Please provide a different implementation of LOAD_32BE instead of __builtin_bswap32.
There was a problem hiding this comment.
#define LOAD_32BE(DEST, ADDR, ARR) { \
uint32_t _val = ((uint32_t*) ARR)[(ADDR) >> 2]; \
DEST = (_val << 24) | ((_val & 0xff00) << 8) | ((_val & 0xff0000) >> 8) | (_val >> 24); \
}
??
There was a problem hiding this comment.
No, I meant using _byteswap_ulong instead of __builtin_bswap32 for the MSVC build.
There was a problem hiding this comment.
#ifdef _MSC_VER
#define LOAD_32BE(DEST, ADDR, ARR) DEST = _byteswap_ulong(((uint32_t*) ARR)[(ADDR) >> 2])
#else
#define LOAD_32BE(DEST, ADDR, ARR) DEST = __builtin_bswap32(((uint32_t*) ARR)[(ADDR) >> 2])
#endif
If I messed this up too, I'll resubmit a squashed clean pr when it's proper fixed.
endrift
requested changes
Oct 2, 2018
|
|
||
| #ifdef _MSC_VER | ||
| #define LOAD_32BE(DEST, ADDR, ARR) DEST = _byteswap_ulong(((uint32_t*) ARR)[(ADDR) >> 2]) | ||
| #else | ||
| #define LOAD_32BE(DEST, ADDR, ARR) DEST = __builtin_bswap32(((uint32_t*) ARR)[(ADDR) >> 2]) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Please remove this extra new line.
| @@ -51,7 +51,9 @@ typedef intptr_t ssize_t; | |||
| #include <sys/time.h> | |||
| typedef intptr_t ssize_t; | |||
| #else | |||
| #ifndef __CELLOS_LV2__ | |||
There was a problem hiding this comment.
I have to rebase my offline work files. Will do that.
|
Dirty pr. Squashing and cleaning up. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.