fix duplicated findings for string-format when there is more than one… #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
suggested changes
Oct 29, 2024
rule/string-format.go
Outdated
| @@ -216,7 +216,7 @@ func (w lintStringFormatRule) Visit(node ast.Node) ast.Visitor { | |||
| for _, rule := range w.rules { | |||
| for _, scope := range rule.scopes { | |||
| if scope.funcName == callName { | |||
| rule.Apply(call) | |||
| rule.apply(call,scope) | |||
There was a problem hiding this comment.
Suggested change
| rule.apply(call,scope) | |
| rule.apply(call, scope) |
rule/string-format.go
Outdated
| } | ||
|
|
There was a problem hiding this comment.
Redundant TAB, can be removed:
Suggested change
alexandear
reviewed
Oct 29, 2024
There was a problem hiding this comment.
I'm suggesting adding the test to verify that the issue is really fixed.
test/string-format_test.go:
func TestStringFormatDuplicatedStrings(t *testing.T) {
testRule(t, "string-format-issue-1063", &rule.StringFormatRule{}, &lint.RuleConfig{
Arguments: lint.Arguments{[]any{
"fmt.Errorf[0],errors.New[0]",
"/^([^A-Z]|$)/",
"must not start with a capital letter",
}},
})
}testdata/string-format-issue-1063.go:
package fixtures
import (
"errors"
)
func ReturnError() error {
return errors.New("This is an error.") // MATCH /must not start with a capital letter/
}
alexandear
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1063 + minor code refactoring