Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prefer XDG_CONFIG_HOME for revive.toml config file #725

Closed
wants to merge 2 commits into from
Closed

feat: prefer XDG_CONFIG_HOME for revive.toml config file #725

wants to merge 2 commits into from

Conversation

notjedi
Copy link

@notjedi notjedi commented Aug 3, 2022 •
edited
Loading

motivation: #724

Checklist

  • Did you add tests?
  • Does your code follows the coding style of the rest of the repository?
  • Does the Travis build passes?

Closes #724

@notjedi
Copy link
Author

notjedi commented Aug 3, 2022 •
edited
Loading

i have only tested this on my linux machine, should most prolly work on darwin and plan9.

EDIT: we can probably use https://github.com/adrg/xdg, so we generalize on all platforms and have the correct fallback directories if XDG_CONFIG_HOME is not set. my current implementation does not fallback to default directories.

mgechev
mgechev reviewed Aug 7, 2022
View reviewed changes
cli/main.go Outdated Show resolved Hide resolved
mgechev
mgechev requested changes Aug 7, 2022
View reviewed changes
Copy link
Owner

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the log statement and merge.

@notjedi notjedi closed this by deleting the head repository Sep 3, 2022
@notjedi notjedi reopened this Oct 10, 2022
@notjedi
Copy link
Author

notjedi commented Oct 10, 2022

i probably forgot about this pr and deleted the repo. my bad, can we pick up where we left? @mgechev

@mfederowicz mfederowicz mentioned this pull request Oct 2, 2023
Merged
@mfederowicz
Copy link
Contributor

@notjedi @mgechev this PR can be closed because all features related this topic we merged in #912 today :)

@chavacava
Copy link
Collaborator

Duplicated of #912

@chavacava chavacava closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer XDG_CONFIG_HOME for getting the revive.toml config file
4 participants
@notjedi @mfederowicz @chavacava @mgechev