-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No error if MANIFEST.in not present #31
Comments
Hm, maybe I should rephrase that description. It's not an error not to have a MANIFEST.in if the default rules of setuptools already pick up every file in every situation. This happens essentially when you only have Python files and maybe a README.txt -- almost any other data files, a tox.ini, or even naming your readme README.rst would cause it not to get picked up, and check-manifest would complain. |
Can you maybe display a warning (not an error) like--
Or perhaps display the warning only if other complaints are being given? This way the user will immediately know a possible cause (e.g. if "MANIFEST.in" was spelled wrong with a typo, etc). |
Oh, interesting. Is this what happened to you? I'm not opposed to a message saying that MANIFEST.in was not found if check-manifest finds other complaints. |
Thanks! |
I'm a new user to this project. When running
check-manifest
with no arguments in a repo with no MANIFEST.in, I got no error that the manifest file was missing.Since check-manifest's usage string says, "Check a Python MANIFEST.in file for completeness," I would expect the command to warn me that no MANIFEST.in is present.
Btw, thanks for a cool project!
The text was updated successfully, but these errors were encountered: