Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of read-only files #74

Closed
adrianschlatter opened this issue Sep 13, 2016 · 6 comments · Fixed by #75
Closed

Handling of read-only files #74

adrianschlatter opened this issue Sep 13, 2016 · 6 comments · Fixed by #75

Comments

@adrianschlatter
Copy link

check-manifest fails with PermissionErrror if it encounters read-only files (see screen-shot below). This is a common situation in svn working-copies with locked files (svn:needs-lock property applied).

I expect that read-only files do not affect the operation of check-manifest (unless the file is missing from the dist, of course).

permissionerror

@mgedmin
Copy link
Owner

mgedmin commented Sep 13, 2016

I was unable to reproduce this on Linux.

Judging from the traceback, the error happens when check-manifest is trying to remove its temporary directory.

The fix is probably to do what 7ad8114 did in tests, only in the main code.

@mgedmin
Copy link
Owner

mgedmin commented Sep 13, 2016

@adrianschlatter: can you test the fix in #75?

@adrianschlatter
Copy link
Author

Confirmed to work properly (i.e., no errors with read-only files) with python2.7 and python3.5. Thanks!

Any idea when that fix will be available on pypi?

@mgedmin
Copy link
Owner

mgedmin commented Sep 14, 2016

I plan to push the fix today.

(It occured to me that maybe I want to add a regression test for this.)

@mgedmin mgedmin reopened this Sep 14, 2016
mgedmin added a commit that referenced this issue Sep 14, 2016
This will act as a regression test for #74.
mgedmin added a commit that referenced this issue Sep 14, 2016
This will act as a regression test for #74.
@mgedmin
Copy link
Owner

mgedmin commented Sep 14, 2016

check-manifest 0.35 is out.

@adrianschlatter
Copy link
Author

It has been a pleasure to work with you ;) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants