-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of read-only files #74
Comments
I was unable to reproduce this on Linux. Judging from the traceback, the error happens when check-manifest is trying to remove its temporary directory. The fix is probably to do what 7ad8114 did in tests, only in the main code. |
@adrianschlatter: can you test the fix in #75? |
Confirmed to work properly (i.e., no errors with read-only files) with python2.7 and python3.5. Thanks! Any idea when that fix will be available on pypi? |
I plan to push the fix today. (It occured to me that maybe I want to add a regression test for this.) |
This will act as a regression test for #74.
This will act as a regression test for #74.
check-manifest 0.35 is out. |
It has been a pleasure to work with you ;) Thanks. |
check-manifest fails with PermissionErrror if it encounters read-only files (see screen-shot below). This is a common situation in svn working-copies with locked files (svn:needs-lock property applied).
I expect that read-only files do not affect the operation of check-manifest (unless the file is missing from the dist, of course).
The text was updated successfully, but these errors were encountered: