Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Unicode filenames with git #24

Merged
merged 1 commit into from
Feb 3, 2014
Merged

Support Unicode filenames with git #24

merged 1 commit into from
Feb 3, 2014

Conversation

myint
Copy link
Contributor

@myint myint commented Feb 2, 2014

This fixes #23.

@mgedmin
Copy link
Owner

mgedmin commented Feb 3, 2014

Ooh, I like how simple this is. And here I was going to implement a C string parser.

mgedmin added a commit that referenced this pull request Feb 3, 2014
@mgedmin
Merge pull request #24 from myint/master
fba87ef 
Support Unicode filenames with git (no tests)
@mgedmin mgedmin merged commit fba87ef into mgedmin:master Feb 3, 2014
mgedmin added a commit that referenced this pull request Feb 3, 2014
@mgedmin
Handle non-ASCII filenames
1aaa341 
As long as they're valid in your locale.

Solution by @myint from #24, but with added tests and an additional
charset decoding fix in run().

Closes #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-ASCII characters in filenames break git ls-files parsing
2 participants
@myint @mgedmin