MarkovChain: add iter and iter_from methods #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods return an iterator which will generate a neverending chain of words. The iterator can be used by itself, or it can be used indirectly by the generate and generate_from methods. The new iterator works slightly differently from the old code in corner cases where the iteration ends up in a state from which there is no next state in the Markov chain. Like before, a new state is picked at random, but this now happens one word earlier than before. This should not make a big difference outside of artificially small test cases.
mgeisler
force-pushed
the
markov-chain-iterator
branch
from
c5b4be2 to
290ed03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods return an iterator which will generate a neverending
chain of words. The iterator can be used by itself, or it can be used
indirectly by the generate and generate_from methods.
The new iterator works slightly differently from the old code in
corner cases where the iteration ends up in a state from which there
is no next state in the Markov chain. Like before, a new state is
picked at random, but this now happens one word earlier than before.
This should not make a big difference outside of artificially small
test cases.