Fix build error on Rust 1.56 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
added a commit
that referenced
this pull request
Jun 6, 2022
Back in 2020, I gave up on trying to keep the library compatible with old Rust releases. This was with the 0.7.0 release which gave up compatibility with Rust 1.31 (the first version of the 2018 edition). Since then, the releases have roughly tracked the latest stable release of Rust, with no particular urgency to bump this of course. This is related to #83 where @WorldSEnder noticed that Lipsum no longer compiles on Rust 1.56. This was easy to fix (#84), but we should still remove the misleading badge.
Something changed between Rust 1.57 and 1.58 so that the slice pattern
doesn’t work without an explicit type annotation in the earlier
version. Without it, we get
```
error[E0277]: expected a `Fn<(char,)>` closure, found `[char; 3]`
--> src/lib.rs:350:52
|
350 | let mut needs_cap = sentence.ends_with(punctuation);
| ^^^^^^^^^^^ expected an `Fn<(char,)>` closure, found `[char; 3]`
|
= help: the trait `Fn<(char,)>` is not implemented for `[char; 3]`
= note: required because of the requirements on the impl of `FnOnce<(char,)>` for `&[char; 3]`
= note: required because of the requirements on the impl of `Pattern<'_>` for `&[char; 3]`
```
Between 1.57 and 1.58, the `Pattern` trait got a new implementation
for `[char; N]`, and I guess this somehow made the code work
afterwards (even though we’re using a `[char]` here).
The problematic code change was introduced in #75.
Fixes #83.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something changed between Rust 1.57 and 1.58 so that the slice pattern doesn’t work without an explicit type annotation in the earlier version. Without it, we get
Between 1.57 and 1.58, the
Patterntrait got a new implementation for[char; N], and I guess this somehow made the code work afterwards (even though we’re using a[char]here).The problematic code change was introduced in #75.
Fixes #83.