Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blanket impl for types that deref to WordSplitter #217

Closed
wants to merge 1 commit into from

Conversation

Benjamin-L
Copy link

I ran into a situation where it would be useful to use &hyphenation::Standard as a splitter. This PR adds a blanket WordSplitter impl for anything that derefs to a WordSplitter, which should cover cases like this.

@Benjamin-L
Copy link
Author

Wow I'm dumb... I accidentally tested without the hyphenation feature. I think this is actually impossible without specialization, so I'm gonna close it.

@Benjamin-L Benjamin-L closed this Oct 26, 2020
@mgeisler
Copy link
Owner

Hey @Benjamin-L,

Okay, no worries! Perhaps we can add some more pointers to the hyphenation feature so it's easier to find?

@Benjamin-L
Copy link
Author

That wasn't my problem. I knew about the hyphenation feature, and had been using it. I just forgot to include it when I built this change to test.

@mgeisler
Copy link
Owner

mgeisler commented Nov 5, 2020

I see, glad you figured it out in any case :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants