Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fill_optimal_fit fuzz target to CI #400

Closed
wants to merge 1 commit into from
Closed

add fill_optimal_fit fuzz target to CI #400

wants to merge 1 commit into from

Conversation

MakotoE
Copy link
Contributor

@MakotoE MakotoE commented Jun 27, 2021

I noticed that the fill_optimal_fit fuzz target was not run in CI so this PR makes the build workflow run this target right after fill_first_fit. fill_first_fit alone does not catch this issue.

@MakotoE
Copy link
Contributor Author

MakotoE commented Jun 27, 2021 •
edited
Loading

Good, the CI run below caught the bug.

thread '<unnamed>' panicked at 'attempt to multiply with overflow', /home/runner/work/textwrap/textwrap/src/wrap_algorithms/optimal_fit.rs:286:21

@mgeisler
Copy link
Owner

Yeah, the fill_optimal_fit test fails, that's why I didn't add it to CI yet. It's #247 again :-)

@mgeisler
Copy link
Owner

This is now fixed via #421.

@mgeisler mgeisler closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MakotoE @mgeisler