Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with stable and nightly, build with 1.56 #518

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

mgeisler
Copy link
Owner

The one-month old fix in #515 has already caused problems because a test dependency has bumped its minimum supported Rust version (MSRV).

It turns out that Textwrap builds fine on old versions of Rust. It builds all the way back to Rust 1.56 which introduced the 2021 edition we use. To better reflect this, we now test with modern versions of Rust and we build with the old version.

The one-month old fix in #515 has already caused problems because a
test dependency has bumped its minimum supported Rust version (MSRV).

It turns out that Textwrap builds fine on old versions of Rust. It
builds all the way back to Rust 1.56 which introduced the 2021 edition
we use. To better reflect this, we now _test_ with modern versions of
Rust and we build with the old version.
@mgeisler mgeisler merged commit 1136d3e into master Sep 23, 2023
25 checks passed
@mgeisler mgeisler deleted the build-with-msrv branch September 23, 2023 11:08
@github-actions github-actions bot mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant