Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): Update unicode-linebreak #534

Closed
wants to merge 1 commit into from
Closed

Conversation

Hywan
Copy link

@Hywan Hywan commented Feb 19, 2024

unicode-linebreak 0.1.5 has been released. It removes the build.rs script (it's moved in another separate internal crate). Moving to 0.1.5 removes the following dependencies from the tree:

  • ahash,
  • aho-corasick,
  • hashbrown,
  • once_cell,
  • regex,
  • regex-syntax,
  • version_check,
  • wasi.

This isn't negligible.

Also, ahash was at version 0.7.6 (latest version is —at the time of writing— 0.8.8), which doesn't compile on Rust nightly. ahash was required by hashbrown, which was required as a build-dependency of unicode-linebreak 0.1.4. It's no longer the case in 0.1.5.

`unicode-linebreak` 0.1.5 has been released. It removes the `build.rs` script (it's moved in another separate internal crate). Moving to 0.1.5 removes the following dependencies from the tree:

* `ahash`,
* `aho-corasick`,
* `hashbrown`,
* `once_cell`,
* `regex`,
* `regex-syntax`,
* `version_check`,
* `wasi`.

This isn't negligible.

Also, `ahash` was at version 0.7.6 (latest version is —at the time of writing— 0.8.8), which doesn't compile on Rust nightly. `ahash` was required by `hashbrown`, which was required as a build-dependency of `unicode-linebreak` 0.1.4. It's no longer the case in 0.1.5.
@mgeisler
Copy link
Owner

mgeisler commented Oct 1, 2024

Thanks for the PR! In the meantime, I've configured Dependabot to send automatic PRs with version updates. So I'll close this now and let the bot update this going forward.

Note that it's not strictly necessary to update dependencies when new patch versions are released: people depending on textwrap will automatically get the latest SemVer compatible version of unicode-linebreak thanks to how Cargo treats a 0.1.4 dependency as ^0.1.4.

@mgeisler mgeisler closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants