Wordsplitter specialization #77
Conversation
|
Looking forward to this getting merged! I already implemented |
This removes the need to box the Wordsplitter, which in turn gives a nicer API. It also makes it possible to have more optimized code, though the benchmarks don't show any consistent improvement.
This function makes it easy to create a terminal-width sized Wrapper while also using a custom WordSplitter.
mgeisler
force-pushed
the
wordsplitter-specialization
branch
from
ab8efc5
to
0af87c0
Compare
|
@hcpl Hi! Oh, that's great to hear :-) I'm still learning Rust, so any tips about how I can improve the API further will be very helpful... |
|
I guess this is less about API being nice and more about practical reasons: since we can just create a new instance when we need another word splitter, we can eliminate redundant boxing. Which coincidentally enables some nifty features like cloning and allows the compiler to do more optimizations. And all that for free! |
|
Yes, and I'm adapting my current implementation to changes now |
This PR changes the
Wrapperstruct so it becomes generic over the type of word splitter used. I think this gives a somewhat better API, but it has the cost that one cannot change the word splitter used on an existing wrapper. I don't think that is something one would do very open, though.