Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing issues #10

Closed
mystygage opened this issue May 15, 2018 · 4 comments · Fixed by #15
Closed

Parsing issues #10

mystygage opened this issue May 15, 2018 · 4 comments · Fixed by #15

Comments

@mystygage
Copy link
Contributor

I defined a workout with two repeats:

workout: 7x1k IV
- warmup: 2km @z2
- repeat: 3
 - run: 100m
 - recover: 1:00
- repeat: 7
 - run: 1000m @z5
 - recover: 400m
- recover: 2km @z2
- cooldown: lap-button

The first repeat is missing in Garmin Connect:

7x1k iv 2018-05-15 15-47-23

@mystygage mystygage changed the title Two repeat steps Parsing issues May 15, 2018
@mystygage
Copy link
Contributor Author

mystygage commented May 15, 2018

I just stumbled upon another error. This workout:

workout: 12k @GA1-2 STL
- run: 12km @z4
- cooldown: lap-button
- repeat: 3
 - run: 100m
 - recover: 1:00

is translated to:
12k stl 2018-05-15 16-10-55

The lap button press step is missing

@mgifos
Copy link
Owner

mgifos commented May 29, 2018

Hi, the second comment is related to the issue #8 and that is fixed. On the other hand I've tried to parse the sample from the original issue description and it went fine. It could be that you have special characters in your sample which we cannot see here. Can you send your sample in csv format and try to import it again with the latest release 0.2.2 - it could be that it's solved by solving the issue #8?

@mystygage
Copy link
Contributor Author

Thanks!
With 0.2.2 it looks like this:
garmin connect 2018-05-31 18-06-51

The lap-button is there, but the repeat step is missing... This is like the problem mentioned in the first comment. It looks like everything after cooldown with lap-button is skipped.

mystygage added a commit to mystygage/quick-plan that referenced this issue Jun 6, 2018
@mgifos
Copy link
Owner

mgifos commented Jun 6, 2018

Great, you decided to give a contribution! I'll take a look after my normal working hours and get back to this.

mystygage added a commit to mystygage/quick-plan that referenced this issue Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants