Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling of previously defined workouts #20

Closed
leingang opened this issue Jul 9, 2018 · 6 comments
Closed

Scheduling of previously defined workouts #20

leingang opened this issue Jul 9, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@leingang
Copy link

leingang commented Jul 9, 2018

It seems like if I have a cell in my CSV file such as:

running: 8E
- run: 8mi
- cooldown: lap-button

and then a later cell with just 8E in it, the expected effect is that the "8E" workout should be defined, then scheduled on both days. The Ultra 80k model CSV file has several repeated workout days like this (e.g., "8k jog" each Wednesday).

Instead, I get it scheduled on the day for which it's defined, but nothing gets scheduled on the later day. Am I doing it wrong?

@mgifos
Copy link
Owner

mgifos commented Jul 9, 2018

Can you attach a complete CSV file to the issue, so I can test it myself?

@mystygage
Copy link
Contributor

I had a similar issue with the training on first Wednesday here (6k @GA1/2+STL): https://docs.google.com/spreadsheets/d/1EXa9QL2AvyIkZIFI239Hf2QPO2ugehQ97-HXvdO4vgg/edit?usp=sharing

It was defined for the day before, but quick-plan didn’t schedule it for Wednesday. Two weeks later it was also scheduled and here everything worked fine.

@mgifos
Copy link
Owner

mgifos commented Jul 9, 2018

Sounds like a problem with asynchronous execution ... e.g. a definition of 6k @GA1/2+STL has not been completed before the scheduling of the first repetition has started. I'm gonna investigate this further by the code staring.

@mgifos
Copy link
Owner

mgifos commented Jul 9, 2018

I managed to reproduce the issue. The bug is confirmed. The problem is if you try to schedule a workout defined in a same week again.

@mgifos mgifos added the bug Something isn't working label Jul 9, 2018
mgifos added a commit that referenced this issue Jul 9, 2018
Workouts definitions can be referenced within a same week. #20
@mgifos mgifos closed this as completed Jul 9, 2018
@leingang
Copy link
Author

Thank you! I look forward to a new release so I can take advantage of this fix.

@mgifos
Copy link
Owner

mgifos commented Jul 30, 2018

Released in v0.2.4

tonybaines pushed a commit to tonybaines/quick-plan that referenced this issue Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants