@phpstan ignore next line replacements #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-ignore-next-line in these cases
|
|
This reverts commit e0b8115.
|
Done, if we land this before #807, it should even work for both the |
mglaman
approved these changes
Nov 18, 2024
|
I'll merge at the computer so I can cherry pick |
mglaman
pushed a commit
that referenced
this pull request
Nov 19, 2024
* [Code] Reworked \mglaman\PHPStanDrupal\Drupal\ExtensionMap::keyByExtensionName * [HACK] Temporarily remove core_baseline test * [Code] Reworked \mglaman\PHPStanDrupal\Drupal\ExtensionMap::keyByExtensionName * [Code] State these @phpstan-ignore-next-line have to stay * [Code] Remov eBC for PHP-Parser 4.x. * [Code] Remove BC for PHP-Parser 4.x. * [Code] Go wild and add an explanation why we want to keep the @phpstan-ignore-next-line in these cases * [Code] More replacements * Revert "[HACK] Temporarily remove core_baseline test" This reverts commit e0b8115.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #808