Improve deprecation handling in unquote function

Fixes sass#1291
mgreter · Jun 23, 2015 · a94f379 · a94f379
1 parent 1657e28
commit a94f379
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/error_handling.cpp b/error_handling.cpp
@@ -20,6 +20,15 @@ namespace Sass {
     warn(msg, pstate);
   }
 
+  void deprecated(string msg, ParserState pstate)
+  {
+    string cwd(Sass::File::get_cwd());
+    cerr << "DEPRECATION WARNING: " << msg << endl;
+    cerr << "will be an error in future versions of Sass." << endl;
+    string rel_path(Sass::File::resolve_relative_path(pstate.path, cwd, cwd));
+    cerr << "        on line " << pstate.line+1 << " of " << rel_path << endl;
+  }
+
   void error(string msg, ParserState pstate)
   {
     throw Sass_Error(Sass_Error::syntax, pstate, msg);

diff --git a/error_handling.hpp b/error_handling.hpp
@@ -24,6 +24,9 @@ namespace Sass {
   void warn(string msg, ParserState pstate);
   void warn(string msg, ParserState pstate, Backtrace* bt);
 
+  void deprecated(string msg, ParserState pstate);
+  // void deprecated(string msg, ParserState pstate, Backtrace* bt);
+
   void error(string msg, ParserState pstate);
   void error(string msg, ParserState pstate, Backtrace* bt);
 

diff --git a/functions.cpp b/functions.cpp
@@ -822,17 +822,21 @@ namespace Sass {
       if (dynamic_cast<Null*>(arg)) {
         return new (ctx.mem) Null(pstate);
       }
-      else if (List* list = dynamic_cast<List*>(arg)) {
-        return list;
-      }
       else if (String_Quoted* string_quoted = dynamic_cast<String_Quoted*>(arg)) {
         String_Constant* result = new (ctx.mem) String_Constant(pstate, string_quoted->value());
         // remember if the string was quoted (color tokens)
         result->sass_fix_1291(string_quoted->quote_mark() != 0);
         return result;
       }
-      To_String to_string(&ctx);
-      return new (ctx.mem) String_Constant(pstate, string(arg->perform(&to_string)));
+      else if (dynamic_cast<String_Constant*>(arg)) {
+        return (Expression*) arg;
+      }
+      else {
+        To_String to_string(&ctx);
+        string val(arg->perform(&to_string));
+        deprecated("Passing " + val + ", a non-string value, to unquote()", pstate);
+        return (Expression*) arg;
+      }
     }
 
     Signature quote_sig = "quote($string)";