Changed authentication link log level #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed authentication link logging statements to warn from debug so they will not be missed if the log level has not been increased.
mguessan
added a commit
that referenced
this pull request
Nov 12, 2023
git-svn-id: https://svn.code.sf.net/p/davmail/code/trunk@3478 3d1905a2-6b24-0410-a738-b14d5a86fcbd
|
For future readers of this PR, note that the level was changed from debug to warn, not the other way around. Maybe @CameronDevine can edit the original message to correct this. |
|
@jdchristensen rereading my original pull request message I believe it is correct. |
|
@CameronDevine Sorry, you're right, I just misread it. |
|
@jdchristensen no problem |
|
I think @mguessan committed this change, so it should be in the most recently released version (6.2.1). Please confirm and then close this issue if so, @CameronDevine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed authentication link logging statements to warn from debug so they will not be missed if the log level has not been increased.
When I was trying to get the
O365Modernmode working I was confused because I couldn't find the link that the document specifies should exist in the logs to complete the login process. I eventually figured out that I needed to increase the log level, but that took a while. To help others in the future I believe the URL should be visible at a lower log level.