relax deps to allow phoenix 1.6 #97
Conversation
|
Love to see this merged in! |
|
is this project abandoned? Why is this not merged yet? |
mix.exs
Outdated
| @@ -49,7 +49,7 @@ defmodule ScrivenerHtml.Mixfile do | |||
| [ | |||
| {:scrivener, "~> 1.2 or ~> 2.0"}, | |||
| {:phoenix_html, "~> 2.2"}, | |||
| {:phoenix, "~> 1.0 and < 1.5.0", optional: true}, | |||
| {:phoenix, "~> 1.0 and < 1.6.0", optional: true}, | |||
There was a problem hiding this comment.
| {:phoenix, "~> 1.0 and < 1.6.0", optional: true}, | |
| {:phoenix, "~> 1.0", optional: true}, |
I don't think it's necessary to keep this constraint
|
@mgwidmann scrivener pagination is really useful for our application but it's blocking us upgrading our application to phoenix 1.5. Can we get this merged in ? |
|
Just sent @mgwidmann an email. Hopefully he responds and maybe we can get this merged in. |
|
Any updates on this? |
|
Noting that #98 is also trying to add support for Phoenix v1.5.x |
|
Are there any updates on this? Still the blocker in upgrading to 1.5.x..... |
|
@jaimeiniesta did you have good success just relaxing the dependencies, or is there more to be done? The PR at https://github.com/mgwidmann/scrivener_html/pull/98/files shows that some tests had to be adapted, but nothing critical. |
|
@thbar yes, I'm using my branch on a Phoenix 1.5.4 app and it works just fine: {:phoenix, "~> 1.5.4"},
{:scrivener_ecto, "~> 2.5.0"},
{:scrivener_list, "~> 2.0.1"},
{:scrivener_html, github: "jaimeiniesta/scrivener_html", branch: "relax_phoenix_dep"} |
|
@mgwidmann Anything preventing this from being merged? PS.: For people upgrading to phoenix 1.5, just add |
|
FYI, I am trying to spread the word in order to find a way to reach Matt, and maybe find a new team of maintainers (even just for simple stuff): |
jaimeiniesta
changed the title
|
Hello @jaimeiniesta! Can you confirm you are using this PR in production? Thanks! @williamweckl you have approved the changes, but do you have merge rights on the repo? |
|
@thbar yes, I'm using this PR in production with Phoenix 1.6.2, Elixir 1.12.3 and it works fine! |
mgwidmann/scrivener_html#97 is not merged at the moment, but required to allow us to upgrade.
* Bump Phoenix & mime * Follow changelog recommendation * Upgrade inter-connected dependencies mgwidmann/scrivener_html#97 is not merged at the moment, but required to allow us to upgrade. * Bump up Phoenix * Follow Phoenix changelog for faster compilation times Source: https://github.com/phoenixframework/phoenix/blob/v1.6/CHANGELOG.md * Fix deprecation in liveview :layout management * Upgrade yarn.lock for phoenix-related dependencies * Fix deprecation error * Fix session management * Proceed with "easy updates" (theoretically) * Invalidate the cache to see if it will fix the MIME compilation error * Fix view_module deprecation in Phoenix 1.6 * Replace ~E by ~H (comes from LiveView, requires `assigns` variable) * Bump up sweet_xml * Bump finch (minor) and oban
|
🎉 thanks! |
* Bump castore * Go back to upstream for scrivener_html See mgwidmann/scrivener_html#97 * Bump plug * Bump yaml_elixir * Bump typed_ecto_schema * Bump timex * Bump sweet_xml * Bump quantum, telemetry * Bump protobuf * Bump postgrex * Bump phoenix * Bump finch * Bump excoveralls * Bump ex_cldr and co * Bump ex_aws * Bump ecto, ecto_sql * Bump earmark * Bump kino * Run "yarn upgrade phoenix" * Update generate_deps_changelogs.exs * Regenerate protobuf bindings * Bump up unzip * Bump mox * Bump live view * Run "mix format" * Fix link
No description provided.