Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyright: pin version and turn on reportAssignmentType + reportIndexIssue #2216

Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 18, 2024

Comment on lines +162 to +163
for tokens in tokenize.tokenize(self.GetNextLine):
self._ProcessToken(*tokens)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been broken since Python 3 !

@Avasam Avasam changed the title pyright: turn on reportIndexIssue + reportIndexIssue pyright: turn on reportAssignmentType + reportIndexIssue Mar 18, 2024
@Avasam Avasam force-pushed the pyright--turn-on-reportIndexIssue-+-reportIndexIssue branch from 22a919f to 1ddd074 Compare March 18, 2024 03:45
@Avasam Avasam force-pushed the pyright--turn-on-reportIndexIssue-+-reportIndexIssue branch from 1ddd074 to f8dc3d0 Compare March 18, 2024 03:45
@Avasam Avasam marked this pull request as draft March 18, 2024 03:47
@Avasam Avasam marked this pull request as ready for review May 10, 2024 03:50
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
@Avasam Avasam changed the title pyright: turn on reportAssignmentType + reportIndexIssue pyright: pin version and turn on reportAssignmentType + reportIndexIssue May 28, 2024
@Avasam Avasam requested a review from mhammond May 28, 2024 04:26
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
@Avasam Avasam merged commit 0731103 into mhammond:main May 28, 2024
27 checks passed
@Avasam Avasam deleted the pyright--turn-on-reportIndexIssue-+-reportIndexIssue branch May 28, 2024 13:44
clin1234 pushed a commit to clin1234/pywin32 that referenced this pull request May 28, 2024
clin1234 pushed a commit to clin1234/pywin32 that referenced this pull request May 29, 2024
clin1234 pushed a commit to clin1234/pywin32 that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants