-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyright: pin version and turn on reportAssignmentType
+ reportIndexIssue
#2216
Merged
Avasam
merged 12 commits into
mhammond:main
from
Avasam:pyright--turn-on-reportIndexIssue-+-reportIndexIssue
May 28, 2024
Merged
pyright: pin version and turn on reportAssignmentType
+ reportIndexIssue
#2216
Avasam
merged 12 commits into
mhammond:main
from
Avasam:pyright--turn-on-reportIndexIssue-+-reportIndexIssue
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Mar 18, 2024
Comment on lines
+162
to
+163
for tokens in tokenize.tokenize(self.GetNextLine): | ||
self._ProcessToken(*tokens) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been broken since Python 3 !
Avasam
changed the title
pyright: turn on
pyright: turn on Mar 18, 2024
reportIndexIssue
+ reportIndexIssue
reportAssignmentType
+ reportIndexIssue
Avasam
force-pushed
the
pyright--turn-on-reportIndexIssue-+-reportIndexIssue
branch
from
March 18, 2024 03:45
22a919f
to
1ddd074
Compare
Work towards reportCallIssue
Avasam
force-pushed
the
pyright--turn-on-reportIndexIssue-+-reportIndexIssue
branch
from
March 18, 2024 03:45
1ddd074
to
f8dc3d0
Compare
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
…https://github.com/Avasam/pywin32 into pyright--turn-on-reportIndexIssue-+-reportIndexIssue
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
Avasam
changed the title
pyright: turn on
pyright: pin version and turn on May 28, 2024
reportAssignmentType
+ reportIndexIssue
reportAssignmentType
+ reportIndexIssue
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
mhammond
approved these changes
May 28, 2024
…ht--turn-on-reportIndexIssue-+-reportIndexIssue
clin1234
pushed a commit
to clin1234/pywin32
that referenced
this pull request
May 28, 2024
clin1234
pushed a commit
to clin1234/pywin32
that referenced
this pull request
May 29, 2024
clin1234
pushed a commit
to clin1234/pywin32
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reportCallIssue
(win32com/server/policy.py tries to call as string #1902 needs to be solved first before enabling that one)