Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adodbapi: reduce _raiseConnectionError and _raiseCursorError to a single argument #2351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Aug 2, 2024

I didn't touch errorHandler's signature because that's a public name and stays PEP 249-compliant

This also ensures the type and value params of errorhandler are consistent.

@Avasam Avasam force-pushed the adodbapi-reduce-_raiseConnectionError-to-a-single-argument branch from 192cf0f to 4109d2c Compare August 2, 2024 01:25
@Avasam Avasam requested a review from vernondcole August 2, 2024 01:25
@Avasam Avasam added the adodbapi label Aug 2, 2024
@Avasam Avasam force-pushed the adodbapi-reduce-_raiseConnectionError-to-a-single-argument branch 2 times, most recently from a08add8 to 21e443b Compare August 2, 2024 01:35
@Avasam Avasam force-pushed the adodbapi-reduce-_raiseConnectionError-to-a-single-argument branch from 21e443b to 1fe28bd Compare August 2, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant