Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline after the match token in error comments #55

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

zhimsel
Copy link
Contributor

@zhimsel zhimsel commented May 31, 2023

For some reason, Github's rendering of markdown is disabled on any line that starts with a comment (<!-- -->). However, markdown rendering resumes on the next line.

This is an easy fix which just adds a newline after the match token.

Testing

I've tested this in my own environment and it works as expected.

zhimsel and others added 3 commits May 31, 2023 12:30
For some reason, Github's rendering of markdown is disabled on any line
that starts with a comment (`<!-- -->`). However, markdown rendering
resumes on the next line.

This is an easy fix which just adds a newline after the match token.
@mheap mheap merged commit 5384b5b into mheap:main Jun 5, 2023
@zhimsel
Copy link
Contributor Author

zhimsel commented Jun 5, 2023

D'oh! Forgot to update the unit tests. Sorry about that. Thanks for merging!

@zhimsel zhimsel deleted the comment-id-newline branch June 5, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants