Fix use-after-free bug in Ctx::initialize #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, init_args was being destructured by value, causing it to be dropped before C_Initialize was called. This caused undefined behavior.
jhagborgftx
force-pushed
the
fix-initialize-ub-for-upstream
branch
from
a5510ad
to
cff3118
Compare
|
Closing all PRs together with the deprecation notice on the README. Please switch to the cryptoki crate which doesn't have this problem to begin with https://github.com/parallaxsecond/rust-cryptoki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, init_args was being destructured by value, causing it to be dropped before C_Initialize was called. This caused undefined behavior. I believe this fixes #49.
The fact that a bug in safe code caused this is a bit worrying. In my opinion, all the function pointers in
CK_FUNCTION_LISTshould be marked as unsafe, and have safe wrappers that take references rather than raw pointers.