Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method_missing for ActiveCampaign module #27

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

tdtadeu
Copy link
Contributor

@tdtadeu tdtadeu commented Aug 16, 2018

Fixes #16 by defining method_missing as a class method, so it's called when running methods on the module directly, such as ::ActiveCampaign.list_list(ids: "all").

@tdtadeu
Copy link
Contributor Author

tdtadeu commented Aug 16, 2018

I was able to fix rubocop config file, but now it returns 13 offenses. I'll see if I can help fixing them later

@mhenrixon
Copy link
Owner

Awesome! Thanks, it is probably time to do some upgrades in the gem.

@tdtadeu
Copy link
Contributor Author

tdtadeu commented Aug 17, 2018

Got 10 of them, but the 3 remaining seem to be related to the complexity of :== method in the configuration. My first idea was to simply remove it completely, but maybe I'm missing where this method is needed?

@tdtadeu
Copy link
Contributor Author

tdtadeu commented Aug 17, 2018

I'm in a bit of a hurry to get things working for my company, but as soon as things cool down I'll look into upgrading the dependencies. I just need a bit of help with the == method in lib/active_campaign/configuration.rb. If it's needed, maybe we should disable complexity checks for the configuration? It's not even that complex 🤓

@mhenrixon mhenrixon merged commit 856b81c into mhenrixon:master Sep 10, 2018
@tdtadeu tdtadeu deleted the method_missing branch April 24, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants