📝 Improve README.md #860
Open
📝 Improve README.md #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changes While reading through documentation I noticed a typo, and in correcting one noticed some others, so I ended up taking a stab at 3 😃 - "therefore" instead of "there for" - This was the first one I noticed, I think this is pretty straightforward. - `sidekiq` and "Sidekiq" instead of "sidekiq" - This one I am less confident of. Some were "sidekiq version" which I interpreted as maybe being "`sidekiq` version". - I capitalized everywhere else it made sense (to me) - Consistent string literals in code - I changed them from being mixed-use to double-quote. This is based off of the StandardRuby guide. If you prefer single-quote, I'm happy to change them all to consistently use that! These were best-guess improvements, if any of the 3 are useful but not all of them, I'm also happy to remove any of them completely 🙇♂️ ### Links - [standardrb guide](https://github.com/standardrb/standard/blob/3abe01cf7ecd13ee7a4fb5b3377430311627a2fc/config/base.yml#L1742-L1745) - [Gitmoji Ref](https://gitmoji.dev/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While reading through documentation I noticed a typo, and one thing led to another 😅
sidekiqand "Sidekiq" instead of "sidekiq"sidekiqversion".These were best-guess improvements, if any of the 3 are useful but not all of them, I'm also happy to remove any of them completely 🙇♂️
Links