-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test ignoring all subdirectories #33
Merged
mherrmann
merged 2 commits into
mherrmann:master
from
excitoon-favorites:ignoreallsubdirectories
Aug 29, 2022
Merged
Added test ignoring all subdirectories #33
mherrmann
merged 2 commits into
mherrmann:master
from
excitoon-favorites:ignoreallsubdirectories
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4da6833
to
b38c5eb
Compare
excitoon
added a commit
to excitoon/gitignorefile
that referenced
this pull request
Aug 27, 2022
excitoon
added a commit
to excitoon/gitignorefile
that referenced
this pull request
Aug 27, 2022
@excitoon the test failed:
Is this a bug or should the |
You will have to fix it. Please check how I did it in my module (with some
explanations):
cpburnz/python-pathspec#41 (comment)
…On Mon, Aug 29, 2022, 1:46 PM Michael Herrmann ***@***.***> wrote:
@excitoon <https://github.com/excitoon> the test failed:
FAIL: test_ignore_all_subdirectories (tests.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/gitignore_parser/gitignore_parser/tests.py", line 1[16](https://github.com/mherrmann/gitignore_parser/runs/8068808829?check_suite_focus=true#step:4:17), in test_ignore_all_subdirectories
self.assertFalse(matches('/home/michael/file.txt'))
AssertionError: True is not false
Is this a bug or should the assertFalse actually be assertTrue?
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSB2XTHU7IOVVL4ZA7RTV3SIHRANCNFSM57VKAMAA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ok; I've reverted your PR. |
Sgtm
…On Mon, Aug 29, 2022, 3:49 PM Michael Herrmann ***@***.***> wrote:
Ok; I've reverted your PR.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSBYJDFNHFTIVGVWCTQLV3SWW7ANCNFSM57VKAMAA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I'm happy to tell that you have one more dependent project now, it's https://github.com/excitoon/3 —
tree
replacement. I've found some bugs while testing.Kind regards,
Vladimir.