Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test ignoring all subdirectories #33

Merged

Conversation

excitoon
Copy link
Contributor

@excitoon excitoon commented Aug 26, 2022

Hi.

I'm happy to tell that you have one more dependent project now, it's https://github.com/excitoon/3tree replacement. I've found some bugs while testing.

Kind regards,
Vladimir.

@excitoon
Copy link
Contributor Author

excitoon added a commit to excitoon/gitignorefile that referenced this pull request Aug 27, 2022
excitoon added a commit to excitoon/gitignorefile that referenced this pull request Aug 27, 2022
@mherrmann mherrmann merged commit da9d8e9 into mherrmann:master Aug 29, 2022
@mherrmann
Copy link
Owner

@excitoon the test failed:

FAIL: test_ignore_all_subdirectories (tests.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/gitignore_parser/gitignore_parser/tests.py", line 1[16](https://github.com/mherrmann/gitignore_parser/runs/8068808829?check_suite_focus=true#step:4:17), in test_ignore_all_subdirectories
    self.assertFalse(matches('/home/michael/file.txt'))
AssertionError: True is not false

Is this a bug or should the assertFalse actually be assertTrue?

@excitoon
Copy link
Contributor Author

excitoon commented Aug 29, 2022 via email

@mherrmann
Copy link
Owner

Ok; I've reverted your PR.

@excitoon
Copy link
Contributor Author

excitoon commented Aug 29, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants