Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup API for discernParser #63

Closed
mhkeller opened this issue Sep 14, 2017 · 2 comments
Closed

Cleanup API for discernParser #63

mhkeller opened this issue Sep 14, 2017 · 2 comments
Assignees

Comments

@mhkeller
Copy link
Owner

mhkeller commented Sep 14, 2017

This function has a weird two argument API because it's designed to take either a delimiter or a file path.

It should instead take a single object that takes {fileName: '', delimiter: ''}.

This would be a breaking change for anyone using the discernParser function directly, which is probably zero, but should still be pushed as a major version update.

@mhkeller
Copy link
Owner Author

mhkeller commented Oct 4, 2017

A better API could be

io.discernParser(stringToTest[, {delimiter: true}])

@mhkeller
Copy link
Owner Author

Fixed via 0a5469c and published in 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant