-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discernParser is documented incorrectly #67
Comments
Ya that's a good catch. It's documented correctly as returning a function that takes a file path but this would make more sense to rename and then separately create functions that expose the parser. |
Yeah, I think it would be good, then it easy to use it in situations where you've read the file by some other mechanism already. |
Wait, it's actually correct, it does return a parser, and works exactly I wanted, so it's just documented incorrectly, hoorah! |
Hooray!
|
FYI i think the usage of this function is a bit bonkers since it has these weird two optional arguments whether it's a file path or a delimiter. I was planning on refactoring it later on when times seem worthy of a breaking change. Something like a first argument as a string and on option options object with io.discernParser(strToTest[,{delimier: true}]) Issue: #63 |
This is fixed via 2c4ec09 |
Published in 3.0.0 |
I was expecting to be able to do this
The text was updated successfully, but these errors were encountered: