Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of detailed: true option on readdirFilter functions #79

Closed
mhkeller opened this issue Aug 13, 2019 · 1 comment · Fixed by #86
Closed

Get rid of detailed: true option on readdirFilter functions #79

mhkeller opened this issue Aug 13, 2019 · 1 comment · Fixed by #86
Milestone

Comments

@mhkeller
Copy link
Owner

I have never ended up using this. If I need the filename I do const fileName = path.basename(fullPath). This option adds a lot of complexity and has been holding up implementing #71 because of how to handle the multiple object types.

This was a recent edition and kinda in the weeks so I'm not sure if anyone is actually using this option. If there are no objections @aubergene @1wheel I will remove and add the recursive option, which is much more useful.

@1wheel
Copy link

1wheel commented Aug 13, 2019

I didn't know there was a detailed option! Won't miss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants