Support passing count as argument to xNice prop (et al.)
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhkeller I'm never 100% sure which docs are generated and which need to be updated, so you might want to double check I didn't overlook something. If this looks good and gets merged, could you publish as |
mhkeller
reviewed
Oct 3, 2022
src/lib/helpers/createScale.js
Outdated
| if (typeof scale.nice === 'function') { | ||
| scale.nice(); | ||
| if (typeof $nice === 'number') { | ||
| scale.nice($nice); |
There was a problem hiding this comment.
Could put this as a conditional inside of the function call?
mhkeller
approved these changes
Oct 3, 2022
mhkeller
reviewed
Oct 3, 2022
| @@ -35,6 +35,7 @@ | |||
| padding={{ right: 10, bottom: 20, left: 25 }} | |||
| x={xKey} | |||
| y={yKey} | |||
| yNice={4} | |||
There was a problem hiding this comment.
Gonna add this to the SSR example too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99
Currently...
...after passing
yNice={4}(which matches AxisYticks = 4default)